-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YOLOv8] Step 0/? Addition of SPP and SPPF Layer #1479
Conversation
Hi @IMvision12 -- super excited about this! Do you have a full version of YOLOv8 working, or are you planning to build it out piece by piece? For code review, it would be nice to have small PRs for one component at a time, but it'd be great to have a full working Colab before we start merging pieces individually. |
@ianstenbit Yeah I am working on colab, will share it |
keras_cv/models/object_detection/yolov8/__internal__/__init__.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I left a first batch of changes on the PR.
keras_cv/models/object_detection/yolov8/__internal__/layers/sppf.py
Outdated
Show resolved
Hide resolved
keras_cv/models/object_detection/yolov8/__internal__/layers/sppf.py
Outdated
Show resolved
Hide resolved
keras_cv/models/object_detection/yolov8/__internal__/layers/sppf.py
Outdated
Show resolved
Hide resolved
keras_cv/models/object_detection/yolov8/__internal__/layers/sppf.py
Outdated
Show resolved
Hide resolved
keras_cv/models/object_detection/yolov8/__internal__/layers/sppf.py
Outdated
Show resolved
Hide resolved
keras_cv/models/object_detection/yolov8/__internal__/layers/sppf.py
Outdated
Show resolved
Hide resolved
keras_cv/models/object_detection/yolov8/__internal__/layers/sppf.py
Outdated
Show resolved
Hide resolved
keras_cv/models/object_detection/yolov8/__internal__/layers/sppf.py
Outdated
Show resolved
Hide resolved
@LukeWood @ianstenbit are we going to add a training script too? till now I have completed with model and loss currently working on training!!! |
Hi @IMvision12 -- this is exciting! In order to verify correctness, we should find a reference implementation and see if we can port its weights and verify numerical equivalence. |
Hi @IMvision12 , thank you so much for the contribution! Would you please update us with the current status of this PR? |
Hii, @haifeng-jin, This PR is probably ready to merge, but as @ianstenbit proposed, we need to first build a complete functional model before we can start merging PRs one by one, so I'm working on creating a full implementation of yolov8 here on my repo: https://github.com/IMvision12/YOLOv8-tf, currently I am working on loss, modeling part is completed. |
Thanks @IMvision12 ! Looking forward to it. |
Hi @IMvision12, would you please let us know a estimated timeline? |
Hello, @haifeng-jin, YOLOV8, and other OD and segmentation models align with my GSoC timeline, so if possible can you please go through the timeline in the proposal? There's a detailed timeline on the proposal. Short answer: I can finish Yolov8 until the last week of April because I have university examinations, and then I can start submitting PRs the first week of May, does this align with your timeline for the release of KerasCV? |
@IMvision12 thanks so much for your contribution! We haven't accepted any GSoC proposals yet and will only have one slot for KerasCV. Would you still be interested in contributing this model outside the GSoC program? |
Yes @jbischof |
@ianstenbit @haifeng-jin @jbischof @LukeWood I can start sending PRs from first week of may |
Added Spatial Pyramid Pooling (SPP) and SPPF layer.
Fixes: #1263
SPP paper : https://arxiv.org/abs/1406.4729
SPPF layer was created by Glenn Jocher which is an optimized version of SPP.
Question: should I create series of many PRs for adding layer 1 by 1 or single PR for everything?
@ianstenbit @LukeWood